Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reaction multi count #47

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Implement reaction multi count #47

merged 1 commit into from
Aug 21, 2017

Conversation

xla
Copy link
Member

@xla xla commented Aug 21, 2017

Since the introduction of reactions one of the biggest impacts on response times for feed/list requests has been the constant overhead of countless network requests in order to populate counters for posts. This is due the nature how we constructed the service interfaces. In this change-set we introduce a specialised method to get all counts for a list of posts at once. After we verify that this does impact the response times significantly we can mirror the same idea in the cache layer.

Since the introduction of reactions one of the biggest impacts on
response times for feed/list requests has been the constant overhead of
countless network requests in order to populate counters for posts. This
is due the nature how we constructed the service interfaces. In this
change-set we introduce a specialised method to get all counts for a
list of posts at once. After we verify that this does impact the
response times significantly we can mirror the same idea in the cache
layer.
@xla xla merged commit 169743d into master Aug 21, 2017
@xla xla deleted the multi-count branch August 21, 2017 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant